[wp-trac] [WordPress Trac] #59689: Function listening to AJAX actions to set `Prefers reduced motion` is affecting whole WP Admin in 6.4 RC

WordPress Trac noreply at wordpress.org
Tue Oct 24 12:14:19 UTC 2023


#59689: Function listening to AJAX actions to set `Prefers reduced motion` is
affecting whole WP Admin in 6.4 RC
--------------------------+-------------------------
 Reporter:  bplv          |       Owner:  joedolson
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  6.4
Component:  Plugins       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by rudlinkon):

 @bplv thanks for your patch. I checked your last patch `59689.4.diff` and
 it looks good to me because at first, you checked the current page
 `plugin-install` by using `window.pagenow !== 'plugin-install'` which will
 prevent to execute any other pages Ajax request. Then you also check is
 settings data string by using `typeof settings.data === "string"` which
 will exclude all other types of settings data.

 Just to keep consistency, I think you can use `'string'` instead of
 `"string"` because you used a single quote for every string.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59689#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list