[wp-trac] [WordPress Trac] #59694: Regression: Fix duotone support to be compatible with enhanced pagination

WordPress Trac noreply at wordpress.org
Tue Oct 24 11:07:16 UTC 2023


#59694: Regression: Fix duotone support to be compatible with enhanced pagination
-------------------------------------------------+-------------------------
 Reporter:  cbravobernal                         |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests gutenberg-  |     Focuses:
  merge dev-reviewed                             |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56997" 56997]:
 {{{
 #!CommitTicketReference repository="" revision="56997"
 Editor: Fix render_duotone_support() to be compatible with enhanced
 pagination.

 Some blocks do not have content. For duotone support, blocks without
 content still need to run through the `render_duotone_support()` to render
 their duotone CSS.

 This fix makes the duotone compatible with the enhanced pagination
 (introduced in 6.4.0) by making sure that the CSS is always on the page,
 even when the posts have no featured image. It also prevents the duotone
 from interfering with other blocks using `wp_unique_id()`.

 References:
 * [https://github.com/WordPress/gutenberg/pull/55415 Gutenberg PR 55415]

 Follow-up to [56226].

 Props cbravobernal, luisherranz, hellofromTonya, isabel_brison, jorbin.
 Reviewed by costdev.
 Merges [56991] and [56996] to the 6.4 branch.
 Fixes #59694.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59694#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list