[wp-trac] [WordPress Trac] #59517: Migrate Puppeteer tests to Playwright

[WordPress Trac]

#59517: Migrate Puppeteer tests to Playwright
--------------------------------------+-------------------------
 Reporter:  swissspidy                |       Owner:  swissspidy
     Type:  enhancement               |      Status:  reopened
 Priority:  normal                    |   Milestone:  6.4
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 It looks like [56926] removed the `PUPPETEER_SKIP_DOWNLOAD` env variable
 from a few workflow files:
 {{{
 .github/workflows/coding-standards.yml
 .github/workflows/end-to-end-tests.yml
 .github/workflows/performance.yml
 .github/workflows/phpunit-tests-run.yml
 .github/workflows/test-coverage.yml
 .github/workflows/test-npm.yml
 }}}

 I noticed a [https://github.com/WordPress/wordpress-
 develop/actions/runs/6538713122/job/17755280330?pr=5503#step:7:34 recent
 test failure] (from 12 hours ago) that seems to be related to this:
 {{{
 npm ERR! code 1
 npm ERR! path /home/runner/work/wordpress-develop/wordpress-
 develop/node_modules/puppeteer
 npm ERR! command failed
 npm ERR! command sh -c -- node install.js
 npm ERR! ERROR: Failed to set up Chromium r1108766! Set
 "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
 npm ERR! Error: read ECONNRESET
 npm ERR!     at TLSWrap.onStreamRead
 (node:internal/stream_base_commons:217:20) {
 npm ERR!   errno: -104,
 npm ERR!   code: 'ECONNRESET',
 npm ERR!   syscall: 'read'
 npm ERR! }
 }}}

 Looking at `package-lock.json`, it appears  that `puppeteer` is still a
 dependency of some packages, specifically `grunt-contrib-qunit`.

 Should the `PUPPETEER_SKIP_DOWNLOAD` env variable perhaps be reinstated
 for now, to avoid downloading Chromium in the workflows that don't need
 it?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59517#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform