[wp-trac] [WordPress Trac] #58164: Background overlay on theme page has layout issues

WordPress Trac noreply at wordpress.org
Mon Oct 16 23:30:49 UTC 2023


#58164: Background overlay on theme page has layout issues
-------------------------------------------------+-------------------------
 Reporter:  zodiac1978                           |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.5
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-testing-info     |     Focuses:  ui, css
  has-patch needs-testing                        |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-screenshots has-testing-info has-patch => has-screenshots
     has-testing-info has-patch needs-testing
 * milestone:  6.4 => 6.5


Comment:

 I'm not sure [attachment:"58164-2.patch"] is ready for commit this late in
 the cycle. Why?

 Though there is a test report for TT2, what about other scenarios such as
 other themes, different submenus, and different viewports (devices)?

 I also tend to agree with @sabernhardt comment:27:
 > We did not need to create a follow-up ticket to close this one with 6.3.
 The `z-index` issue was already reported in #41155, and that ticket
 probably could address the height issue too. Should we continue the
 discussion (and move the patch) there?

 #41155 predates this ticket. Rather than solving the z-index and height
 issue here, might be better to move the discussion and
 [attachment:"58164-2.patch"] to #41155.

 Moving this ticket to 6.5. But if there's high confidence that the patch
 does indeed fix the z-index and height issues across all themes and
 viewport sizes, then it could be considered for 6.4, though RC1 is
 ~16(ish) hours.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58164#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list