[wp-trac] [WordPress Trac] #58443: Twenty Nineteen Button is having issue with line height.

WordPress Trac noreply at wordpress.org
Mon Oct 16 13:42:44 UTC 2023


#58443: Twenty Nineteen Button is having issue with line height.
-------------------------------------------------+-------------------------
 Reporter:  nidhidhandhukiya                     |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  Bundled Theme                        |     Version:  6.2.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info has-patch has-      |     Focuses:
  screenshots needs-testing                      |
-------------------------------------------------+-------------------------

Comment (by sabernhardt):

 I needed to edit two statements in #comment:13 because they were not
 entirely accurate.

 PR 5431 is an improvement but not thorough. It adds support for the line
 height setting on the front end when applied to individual Button blocks,
 yet not when trying to set a line height on the parent Buttons block.
 Whether that is good enough or should be applied to `.wp-block-buttons`
 instead, I would like at least the same change in the theme's editor
 styles.

 For quicker testing, you could copy and paste a
 [https://gist.github.com/sabernhardt/942e36beed59b664db5c8803f57f08ec set
 of Button blocks]. The first set focuses on the default typography styles
 and custom line height, and the second set includes several other custom
 typography options (Twenty Nineteen still would not support a custom font
 weight or text decoration).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58443#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list