[wp-trac] [WordPress Trac] #59591: Missing checks for pattern files trigger (invisible) PHP warnings

[WordPress Trac]

#59591: Missing checks for pattern files trigger (invisible) PHP warnings
---------------------------------------+--------------------------
 Reporter:  afercia                    |       Owner:  flixos90
     Type:  defect (bug)               |      Status:  reopened
 Priority:  normal                     |   Milestone:  6.4
Component:  Themes                     |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  performance
---------------------------------------+--------------------------
Changes (by afercia):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @flixos90 when a ticket has the `2nd-opinion` keyword, that means
 _another_ person who is not one of the people who implemented the feature
 is needed to express an opinion. See
 https://make.wordpress.org/core/handbook/contribute/trac/keywords/#action-
 based-keywords

 I understand you are attached to this feature as you are part of the team
 that implemented it. However, I would like to hear thoughts from _other_
 committers and tech leads. For this reason, I'm going to reopen again this
 ticket. Also, before closing a ticket it would be fair to check if there
 is consensus.

 I feel this issue is being viewed a bit too much under a _technical_
 perspective. I'm not interested in a "formally correct" technical
 approach. My concern is that this caching mechanism will break the flow of
 many users. Just to mention one scenario: professionals who manage several
 sites for their customers and upload stuff via FTP. I think the user
 experience here has been overlooked and I would like to hear second
 opinions from people outside of the team who implemented this feature.
 Thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59591#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform