[wp-trac] [WordPress Trac] #59591: Missing checks for pattern files trigger (invisible) PHP warnings

[WordPress Trac]

#59591: Missing checks for pattern files trigger (invisible) PHP warnings
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4
Component:  Themes                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch 2nd-       |     Focuses:
  opinion dev-feedback                           |  performance
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch 2nd-
     opinion dev-feedback
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 > In order to make direct changes to the theme (a.k.a. develop the theme),
 you should define the WP_DEVELOPMENT_MODE constant and set it to "theme"
 in wp-config.php. This will ensure any theme specific caching is disabled
 while you're making changes.

 I'm not sure this answers my question.

 As a site owner, I'm not required to know what the WP_DEVELOPMENT_MODE
 constant is. I just want to upload a new pattern file to my directory and
 I'd expect it to just work.

 Actually, in this scenario, as a site owner I'm not even _editing_ the
 theme. I'm just uploading a new pattern file. This is a pretty common
 scenario and I don't think it is covered by the current implementation.

 I'm pretty sure there are more scenarios that I can't think of right now
 that may be very confusing for users. At the very least the caching
 mechanism should be very well explained in the UI. It should not be an
 invisible feature. I'd also think there should be a button in the UI to
 allow users to invalidate the cache.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59591#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform