[wp-trac] [WordPress Trac] #59431: Revisions: get a deprecation error about WP_Text_Diff_Renderer_Table::__isset()

[WordPress Trac]

#59431: Revisions: get a deprecation error about
WP_Text_Diff_Renderer_Table::__isset()
-----------------------------------------------+---------------------------
 Reporter:  wildworks                          |       Owner:
                                               |  hellofromTonya
     Type:  defect (bug)                       |      Status:  closed
 Priority:  normal                             |   Milestone:  6.4
Component:  Revisions                          |     Version:  trunk
 Severity:  minor                              |  Resolution:  fixed
 Keywords:  has-patch has-testing-info commit  |     Focuses:
-----------------------------------------------+---------------------------
Changes (by hellofromTonya):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56938" 56938]:
 {{{
 #!CommitTicketReference repository="" revision="56938"
 Code Modernization: Declare dynamic properties on
 WP_Text_Diff_Renderer_Table.

 Core uses 3 known, named, dynamic properties on the
 `WP_Text_Diff_Renderer_Table` class:

 * `_title`
 * `_title_left`
 * `_title_right`

 When reviewing revisions (within the admin UI), `wp_text_diff()` passes
 the arguments (without the leading `_`) to a new instance, which raised
 deprecation notices (see [56354]).

 Note: the parent class adds the leading `_` to each of these properties
 (see [7747]).

 The deprecation notices are resolved by declaring each of these known,
 named, dynamic properties on the class, per the #56034 mitigation
 strategy. These new properties are not initialized to retain their
 previous `null` behavior.

 Follow-up to [56354], [23506], [7747].

 Props wildworks, antonvlasenko, hellofromTonya, ironprogrammer, kafleg,
 mukesh27, nicolefurlan, presskopp, sabernhardt.
 Fixes #59431.
 See #58898, #56034.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59431#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform