[wp-trac] [WordPress Trac] #59566: Twenty Nineteen: The color palette shows incorrect names

[WordPress Trac]

#59566: Twenty Nineteen: The color palette shows incorrect names
-------------------------------------------------+-------------------------
 Reporter:  poena                                |       Owner:  poena
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  Bundled Theme                        |     Version:  5.3
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-screenshots has-       |     Focuses:
  testing-info commit                            |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56935" 56935]:
 {{{
 #!CommitTicketReference repository="" revision="56935"
 Twenty Nineteen: Correctly display default color names in the color
 palette.

 Instead of displaying the color names, two of the default colors displayed
 the color code, which was only intended to show when the user has enabled
 the custom color option in the Customizer.

 The reason is that the default value for the option is `false`, and this
 value is changed to the string `'custom'` if the color option is enabled,
 and the string `'default'` if the custom color is enabled and then reset
 to default colors.

 This commit adjusts the logic for displaying the color name, to make sure
 that the string value `'default'` is not compared with `false`, by adding
 the default value as a parameter to `get_theme_mod( 'primary_color' )`.

 Follow-up to [45964].

 Props poena, mukesh27, ugyensupport, shailu25, anveshika, harshgajipara,
 nicolefurlan, syamraj24, balub, vivekawsm.
 Fixes #59566.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59566#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform