[wp-trac] [WordPress Trac] #57979: Can't upload images to WordPress Comments

[WordPress Trac]

#57979: Can't upload images to WordPress Comments
-------------------------------------------------+-------------------------
 Reporter:  sbb                                  |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.4
Component:  Comments                             |     Version:  6.0.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion dev-feedback   |     Focuses:
  needs-testing                                  |  administration
-------------------------------------------------+-------------------------

Comment (by davidbaumwald):

 @nicolefurlan Thanks for the ping!  I actually don't think the latest
 patch is quite ready yet.  The unit tests are failing on the
 [https://github.com/WordPress/wordpress-develop/pull/4265 4265 PR] and I
 don't think it's the right approach.  Sergey's suggestion is more
 appropriate so that the commenter's capabilities are only checked if the
 current user's capes don't include `unfiltered_html`.

 I created [https://github.com/WordPress/wordpress-develop/pull/5485 PR
 #5485] to get that approach working, but we might need to rework the tests
 a bit.

 @SergeyBiryukov do you think that the expected result in
 `test_update_comment_from_unprivileged_user_by_privileged_user` should
 actually be reversed with this change?  If we allow a privileged user to
 post unfiltered HTML as proposed here, this test would need to be adjusted
 to check that `disallowed=attribute` is included in the expected result.
 Thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57979#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform