[wp-trac] [WordPress Trac] #57775: wp_create_file_in_uploads Called as Action Hook

WordPress Trac noreply at wordpress.org
Fri Oct 13 12:18:34 UTC 2023


#57775: wp_create_file_in_uploads Called as Action Hook
-------------------------------------------------+-------------------------
 Reporter:  Howdy_McGee                          |       Owner:
                                                 |  johnbillion
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  General                              |     Version:  2.5
 Severity:  trivial                              |  Resolution:  fixed
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56929" 56929]:
 {{{
 #!CommitTicketReference repository="" revision="56929"
 Media: Consistently call the `wp_create_file_in_uploads` hook as a filter.

 The filter was initially introduced for file replication purposes. Since
 the returned value is not always used directly, some instances were later
 converted to an action as part of removing unused variables, and the hook
 was documented as an action while still being called as a filter in other
 instances.

 This commit aims to correct the discrepancy between the code and the
 documentation.

 Follow-up to [4673], [4817], [4818], [6363], [6551], [13041], [25821],
 [33154], [33280].

 Props Howdy_McGee, nicolefurlan, johnbillion, mhshujon, SergeyBiryukov.
 Fixes #57775.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57775#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list