[wp-trac] [WordPress Trac] #59583: Patterns: `theme` attribute not inserted in Template Part blocks

[WordPress Trac]

#59583: Patterns: `theme` attribute not inserted in Template Part blocks
--------------------------------------+------------------------------
 Reporter:  Bernhard Reiter           |       Owner:  Bernhard Reiter
     Type:  defect (bug)              |      Status:  reopened
 Priority:  high                      |   Milestone:  6.4
Component:  General                   |     Version:
 Severity:  major                     |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+------------------------------

Comment (by gziolo):

 > Unfortunately, the apparent performance enhancement [56805] came almost
 entirely from the bug it introduced. Due to no longer injecting the theme
 attribute to all core/template-part blocks, those blocks would no run any
 of the logic within
 https://github.com/WordPress/gutenberg/pull/55217/files#diff-
 28f36bb64fbbc8ce728db401b1e4cf30c9f44db7f5dcce1b7b0cc9ce60b1a209L22, which
 has a considerable cost.

 Excellent discovery, @flixos90. It took me a while to realize that even
 after reading your comment too fast yesterday. That's the crux of it for
 TT4 which uses many patterns referencing template parts. In particular, on
 the homepage the impact was high because with the bug introduced, all
 these template part weren't processed because of the missing `theme`
 attribute, which prevented displaying them at all.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59583#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform