[wp-trac] [WordPress Trac] #59360: update_network_option() strict checks can cause false negatives

[WordPress Trac]

#59360: update_network_option() strict checks can cause false negatives
-------------------------------------------------+-------------------------
 Reporter:  mukesh27                             |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests has-patch commit      |     Focuses:
  dev-feedback                                   |  performance
-------------------------------------------------+-------------------------
Changes (by costdev):

 * keywords:  has-unit-tests has-patch commit => has-unit-tests has-patch
     commit dev-feedback


Comment:

 @mukesh27 @flixos90 @joemcgill @hellofromTonya With logic revisions under
 discussion, a BC break pending investigation, confirmation, and test
 updates, I'm thinking we should revert for 6.4 and reconsider our strategy
 here.

 This component is so crucial for plugins, and despite having a possible
 fix for the latest issue, we've now identified a few breaks during this
 work and it's getting late in the cycle. I'm not yet confident that we
 have a stable enough patch for release.

 Given this, I'd propose that we:
 - Revert the commits for this ticket and the `update_option()` ticket
 (#22192).
 - Do more testing with various plugins to determine possible breakages.
 - Revisit our existing test coverage.
 - Commit the tests during the 6.5 cycle.
 - With improved knowledge and tests, look again at exactly what we
 want/can/should achieve.

 What are your thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59360#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform