[wp-trac] [WordPress Trac] #22192: update_option() strict checks can cause false negatives

WordPress Trac noreply at wordpress.org
Wed Oct 11 19:36:48 UTC 2023


#22192: update_option() strict checks can cause false negatives
--------------------------------------------+--------------------------
 Reporter:  nacin                           |       Owner:  joemcgill
     Type:  defect (bug)                    |      Status:  assigned
 Priority:  normal                          |   Milestone:  6.4
Component:  Options, Meta APIs              |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch has-unit-tests close  |     Focuses:  performance
--------------------------------------------+--------------------------

Comment (by azaozz):

 Replying to [comment:91 flixos90]:
 > this means for options with pre filters, the original purpose of this
 ticket won't get fixed. But I think that is a better trade off than the
 breakage we're seeing from the workaround of temporarily unhooking
 filters, and it's overall an edge-case anyway.

 +1. Ran into this when working on the patch to add data type support for
 options. The "proper" solution seems to be to trust that the plugins that
 user the `pre_` filters will do the right thing :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/22192#comment:93>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list