[wp-trac] [WordPress Trac] #22192: update_option() strict checks can cause false negatives

WordPress Trac noreply at wordpress.org
Wed Oct 11 15:23:59 UTC 2023


#22192: update_option() strict checks can cause false negatives
--------------------------------------------+--------------------------
 Reporter:  nacin                           |       Owner:  mukesh27
     Type:  defect (bug)                    |      Status:  reopened
 Priority:  normal                          |   Milestone:  6.4
Component:  Options, Meta APIs              |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch has-unit-tests close  |     Focuses:  performance
--------------------------------------------+--------------------------

Comment (by flixos90):

 Sharing here the suggestion by @joemcgill from
 https://wordpress.slack.com/archives/C02KGN5K076/p1697034922980339, which
 I think is a great alternative solution: If any `pre` filters are present,
 we should play it safe and stick to the previous logic.

 Effectively, this means for options with pre filters, the original purpose
 of this ticket won't get fixed. But I think that is a better trade off
 than the breakage we're seeing from the workaround of temporarily
 unhooking filters, and it's overall an edge-case anyway. So I am in favor
 of going that route.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/22192#comment:91>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list