[wp-trac] [WordPress Trac] #58902: add_query_arg() should esc_url_raw() REQUEST_URI

WordPress Trac noreply at wordpress.org
Tue Oct 10 18:55:11 UTC 2023


#58902: add_query_arg() should esc_url_raw() REQUEST_URI
-------------------------------------------------+-------------------------
 Reporter:  jorbin                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.4
Component:  Formatting                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-testing-info has-      |     Focuses:
  unit-tests changes-requested                   |
-------------------------------------------------+-------------------------

Comment (by oglekler):

 @ivanzhuck you are changing the test line that was added for another issue
 11 years ago:
 https://core.trac.wordpress.org/changeset/1192/tests
 I believe that it should be left like it is.

 This is the tests dedicated to URLs:
 https://github.com/WordPress/wordpress-
 develop/blob/trunk/tests/phpunit/tests/formatting/escUrl.php

 To make sure that `add_query_arg()` will always return a sanitized URL, I
 assume it needs a separate test with URLs where there is something to
 sanitize.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58902#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list