[wp-trac] [WordPress Trac] #59431: Revisions: get a deprecation error about WP_Text_Diff_Renderer_Table::__isset()

[WordPress Trac]

#59431: Revisions: get a deprecation error about
WP_Text_Diff_Renderer_Table::__isset()
-------------------------------------+-----------------------------
 Reporter:  wildworks                |       Owner:  hellofromTonya
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  6.4
Component:  Revisions                |     Version:  trunk
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------

Comment (by antonvlasenko):

 == Test Report

 Patch tested: https://github.com/WordPress/wordpress-develop/pull/5453

 === Steps to Reproduce or Test
 1. Turn on `WP_DEBUG` and `WP_SCRIPT_DEBUG`.
 2. Create a post.
 3. Make changes and save several times.
 4. Click "X Revisions" in the right sidebar.
 5. 🐞Observe several errors on the page:
 {{{
 Deprecated: WP_Text_Diff_Renderer_Table::__isset(): The property `_title`
 is not declared. Checking `isset()` on a dynamic property is deprecated
 since version 6.4.0! Instead, declare the property on the class.
 Deprecated: WP_Text_Diff_Renderer_Table::__isset(): The property
 `_title_left` is not declared. Checking `isset()` on a dynamic property is
 deprecated since version 6.4.0! Instead, declare the property on the
 class.
 Deprecated: WP_Text_Diff_Renderer_Table::__isset(): The property
 `_title_right` is not declared. Checking `isset()` on a dynamic property
 is deprecated since version 6.4.0! Instead, declare the property on the
 class.
 }}}

 === Expected Results
 When testing a patch to validate it works as expected:
 - ✅ There should be no errors on the revisions page.

 When reproducing a bug:
 - ❌ Observe the errors mentioned above.

 === Environment
 - WordPress: 6.4-beta2-56769-src
 - PHP: 7.3.33
 - Server: Apache/2.4.57 (Unix) PHP/7.3.33
 - Database: mysqli (Server: 5.7.43 / Client: Unavailable)
 - Browser: Safari 17.0 (macOS)
 - Theme: Twenty Twenty-Three 1.2
 - MU-Plugins: None activated
 - Plugins: None

 ==== Actual Results
 When reproducing a bug/defect:
 - ❌ Errors observed on the revisions page.

 When testing the bugfix patch:
 - ✅ No errors on the revisions page.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59431#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform