[wp-trac] [WordPress Trac] #59557: Twenty Nineteen: The required WordPress versions do not match (was: Twenty Ninteen: The required WordPress versions do not match)

[WordPress Trac]

#59557: Twenty Nineteen: The required WordPress versions do not match
---------------------------+---------------------
 Reporter:  poena          |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  6.4
Component:  Bundled Theme  |     Version:  5.0
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+---------------------
Description changed by SergeyBiryukov:

Old description:

> In the readme, style.scss and style.css files, the required WordPress
> version is set to 4.9.6:
> {{{
> Requires at least: 4.9.6
> }}}
> But in functions.php, the minimum version is 4.7.
> It has been 4.7 since https://core.trac.wordpress.org/ticket/45424
> {{{
> /**
>  * Twenty Nineteen only works in WordPress 4.7 or later.
>  */
> if ( version_compare( $GLOBALS['wp_version'], '4.7', '<' ) ) {
>         require get_template_directory() . '/inc/back-compat.php';
>         return;
> }
> }}}
>
> Since there may already be installations on 4.7, the file headers should
> be updated to say 4.7.
>
> [https://github.com/WordPress/twentynineteen/issues/207 A previous
> conversation ] about the required version mentions that the version needs
> to be 4.9.6 because the theme uses {{{the_privacy_policy_link()}}}. But
> {{{the_privacy_policy_link()}}} is wrapped inside a function_exist:
>
> {{{
> if ( function_exists( 'the_privacy_policy_link' ) ) {
>         the_privacy_policy_link( '', '<span role="separator" aria-
> hidden="true"></span>' );
> }
>
> }}}
>
> Other relevant discussions:
> https://github.com/WordPress/twentynineteen/issues/431
> https://github.com/WordPress/twentynineteen/pull/432

New description:

 In the readme, style.scss and style.css files, the required WordPress
 version is set to 4.9.6:
 {{{
 Requires at least: 4.9.6
 }}}
 But in functions.php, the minimum version is 4.7.
 It has been 4.7 since #45424.
 {{{
 /**
  * Twenty Nineteen only works in WordPress 4.7 or later.
  */
 if ( version_compare( $GLOBALS['wp_version'], '4.7', '<' ) ) {
         require get_template_directory() . '/inc/back-compat.php';
         return;
 }
 }}}

 Since there may already be installations on 4.7, the file headers should
 be updated to say 4.7.

 [https://github.com/WordPress/twentynineteen/issues/207 A previous
 conversation ] about the required version mentions that the version needs
 to be 4.9.6 because the theme uses {{{the_privacy_policy_link()}}}. But
 {{{the_privacy_policy_link()}}} is wrapped inside a function_exist:

 {{{
 if ( function_exists( 'the_privacy_policy_link' ) ) {
         the_privacy_policy_link( '', '<span role="separator" aria-
 hidden="true"></span>' );
 }

 }}}

 Other relevant discussions:
 https://github.com/WordPress/twentynineteen/issues/431
 https://github.com/WordPress/twentynineteen/pull/432

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59557#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform