[wp-trac] [WordPress Trac] #57512: Warning as a part of API response

WordPress Trac noreply at wordpress.org
Mon Oct 9 14:48:15 UTC 2023


#57512: Warning as a part of API response
-------------------------------------------------+-------------------------
 Reporter:  kalpeshh                             |       Owner:  kadamwhite
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4
Component:  REST API                             |     Version:  6.1.1
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  php80 has-unit-tests has-patch has-  |     Focuses:  rest-api
  testing-info commit                            |
-------------------------------------------------+-------------------------
Changes (by kadamwhite):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56804" 56804]:
 {{{
 #!CommitTicketReference repository="" revision="56804"
 REST API: Correct parsing of password from Authorization header when
 processing Application Password credentials.

 Exit early when parsing Application Password credentials if Authorization
 header value does not contain at least one colon. The `Authorization`
 Basic header must use a colon to separate the username and password
 components per RFC 7617, so a username-only string is malformed and should
 not be processed.

 Split `Authorization` header only on the first colon, properly handling
 passwords containing colons.

 Resolves PHP 8.0 warning when `list()` was called on an exploded
 credentials array containing only one element.

 Props kalpeshh, shooper, sc0ttkclark, jrf, mukesh27, oglekler,
 nicolefurlan.
 Fixes #57512.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57512#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list