[wp-trac] [WordPress Trac] #58910: Reconsider wp_add_fields_to_navigation_fallback_embedded_links() location

WordPress Trac noreply at wordpress.org
Fri Oct 6 14:02:24 UTC 2023


#58910: Reconsider wp_add_fields_to_navigation_fallback_embedded_links() location
---------------------------------------------------+-----------------------
 Reporter:  SergeyBiryukov                         |       Owner:  (none)
     Type:  defect (bug)                           |      Status:  new
 Priority:  normal                                 |   Milestone:  6.5
Component:  Editor                                 |     Version:  6.3
 Severity:  normal                                 |  Resolution:
 Keywords:  has-patch has-unit-tests dev-feedback  |     Focuses:  rest-api
---------------------------------------------------+-----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:20 ramonopoly]:
 > If we don't want to extend `WP_REST_Posts_Controller`, what about adding
 the hook as a public method of `WP_Navigation_Fallback`?

 Indeed, [https://github.com/WordPress/wordpress-develop/pull/4957 PR 4957]
 appears to be the most straightforward way to resolve this for now.

 [https://github.com/WordPress/wordpress-develop/pull/4949 PR 4949] could
 be an option too, though if my reading of comment:16 is correct, whether
 or not extending `WP_REST_Posts_Controller` is the correct approach here
 could use some more discussion.

 I think we can proceed with [https://github.com/WordPress/wordpress-
 develop/pull/4957 PR 4957] at this time, and perhaps explore the other
 option in a future release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58910#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list