[wp-trac] [WordPress Trac] #59443: Block Supports: Re-use instance of Tag Processor when adding layout classes

[WordPress Trac]

#59443: Block Supports: Re-use instance of Tag Processor when adding layout classes
---------------------------------------+----------------------------
 Reporter:  dmsnell                    |       Owner:  isabel_brison
     Type:  enhancement                |      Status:  reopened
 Priority:  normal                     |   Milestone:  6.4
Component:  Editor                     |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  gutenberg-merge has-patch  |     Focuses:  performance
---------------------------------------+----------------------------

Comment (by spacedmonkey):

 As requested, here is data from reverting this change.

 Trunk is core commit [56766]. Here is data from different block themes.

 === TT4

 || Version || Function time || Times called     || Total server time ||
 || Trunk   || 18.9 ms || 279 || 176ms ||
 || Revert ||    30.4 ms || 279  || 184ms ||

 === TT3

 || Version || Function time || Times called     || Total server time ||
 || Trunk   || 5.98 ms || 444 || 152ms ||
 || Revert ||  10 ms || 444  || 148ms ||

 === Ollie

 || Version || Function time || Times called     || Total server time ||
 || Trunk   ||   17.3 ms || 509 || 226ms ||
 || Revert ||    33.4 ms || 509  || 242ms ||

 === Frost

 || Version || Function time || Times called     || Total server time ||
 || Trunk   || 8.68 ms || 66 || 111ms ||
 || Revert ||  14.4 ms || 66  || 114ms ||


 So, just reverting this change, we are seeing a net benefit. Which is
 confusing, is in the first run the function was slower. What other changes
 could have effect this function in WP 6.4. This function also result is
 around 7-17% of server time. If we can look at the performance of this
 function and make some improvements, it will be well worth it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59443#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform