[wp-trac] [WordPress Trac] #51352: Unexpected behavior when switching autoload between update_option

WordPress Trac noreply at wordpress.org
Wed Oct 4 18:44:22 UTC 2023


#51352: Unexpected behavior when switching autoload between update_option
-------------------------------------------------+-------------------------
 Reporter:  pentatonicfunk                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.4
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback needs-refresh needs-testing           |
-------------------------------------------------+-------------------------
Changes (by joemcgill):

 * keywords:  has-patch has-unit-tests 2nd-opinion dev-feedback => has-patch
     has-unit-tests dev-feedback needs-refresh needs-testing


Comment:

 Thanks @nicolefurlan. Reading through this conversation, this looks like a
 well described bug with initial unit tests from the first PR that was
 added, but with a second PR that only includes a fix (not the tests). The
 PR needs a refresh that includes tests and someone to review/test.

 Given that we're explicitly adding functionality in this release via
 #58964 to allow autoload values to be changed, it seems sensible to also
 make sure caches are being properly cleared to avoid returning stale
 values when calling `get_option()`, which is my understanding of this bug.

 @kkmuffme if you (or someone else) has time to update the PR we can try to
 get this in, but really needs to land before Oct 10 so it's in the final
 beta of this release. Otherwise, this can continue in a future release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51352#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list