[wp-trac] [WordPress Trac] #45929: Potential assignment to empty string

[WordPress Trac]

#45929: Potential assignment to empty string
-------------------------------------------------+-------------------------
 Reporter:  jugglinmike                          |       Owner:  joedolson
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.4
Component:  Shortcodes                           |     Version:  5.0.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch changes-requested good-    |     Focuses:
  first-bug has-unit-tests                       |
-------------------------------------------------+-------------------------

Comment (by brianhenryie):

 The patch certainly solves the problem as described.

 There is a related issue – https://core.trac.wordpress.org/ticket/59249 –
 which will actually address this same ticket by only returning an empty
 array and never the empty string that was the cause here.

 The first post of this thread says:

 > But it seems like a few things should change in core:
 >
 >  *  updating the documented type of the $attr parameter of shortcode
 functions
 >  *  tolerating the empty string

 The first will incorrect after 59249, so has not been done.
 The second has been done with the patch (now PR 5375).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45929#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform