[wp-trac] [WordPress Trac] #58407: resetpassword action on users.php (users list page) handles retrieve_password() return incorrectly

[WordPress Trac]

#58407: resetpassword action on users.php (users list page) handles
retrieve_password() return incorrectly
-------------------------------------------------+-------------------------
 Reporter:  letraceursnork                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.4
Component:  Users                                |     Version:  6.2.2
 Severity:  trivial                              |  Resolution:
 Keywords:  good-first-bug has-patch changes-    |     Focuses:  ui,
  requested                                      |  administration
-------------------------------------------------+-------------------------
Changes (by oglekler):

 * keywords:  good-first-bug has-patch needs-testing needs-testing-info =>
     good-first-bug has-patch changes-requested


Comment:

 In the `retrieve_password()` function there is a shortcut that is
 returning `true` well before `wp_email()`, so when this function is
 returning true, it isn't a fact that email has been sent.

 In the current patch the part in the `ajax-actions.php` from my point of
 view has no sense, because `retrieve_password()` is only returns true or
 an error object and an error cannot be a success.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58407#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform