[wp-trac] [WordPress Trac] #59465: Twenty Twenty-Four performance assessment and opportunities

[WordPress Trac]

#59465: Twenty Twenty-Four performance assessment and opportunities
----------------------------+--------------------------
 Reporter:  flixos90        |       Owner:  flixos90
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  6.4
Component:  Bundled Theme   |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  performance
----------------------------+--------------------------

Comment (by onemaggie):

 Replying to [comment:21 flixos90]:
 > Thank you for the additional input @dmsnell!
 >
 > A mentioned earlier, I think the root problem with the server-side
 performance lies in core itself, and is now being further explored via
 #59490. Regarding TT4 itself, there may be room for a bit of optimization,
 but IMO it wouldn't tackle the problem at its root. That said, there are a
 few instances where I would question the use of patterns to be excessive,
 for example:
 > *
 https://github.com/WordPress/twentytwentyfour/blob/trunk/templates/home.html
 simply points to...
 > * https://github.com/WordPress/twentytwentyfour/blob/trunk/patterns
 /template-home-business.php, which points to...
 > *
 https://github.com/WordPress/twentytwentyfour/blob/trunk/patterns/page-01
 -business-home.php, which points to 6 other patterns
 >
 > Couldn't all those 6 patterns simply be referenced in the root
 `templates/home.html` file? Why the 2 additional "patterns" in between,
 which don't really add anything AFAIK? Curious if you can share come
 context on that @onemaggie @luminuu.
 >
 > I've added links to the 3 more specific tickets related to the
 performance issues to the description.

 The way it works is:

 - page-01-business-home.php has the content between the header and the
 footer, and makes it available as a full page pattern to be used in any
 page on the **page creation flow** (you will get a popup that shows you
 the theme patterns that are tagged as "page" patterns with the post-
 content block type
 - template-home-business.php is the full page with header and footer, and
 it needs to exist as a pattern so that it's available on the **template
 creation/swapping flow**. As of now, only patterns show in this flow, not
 existing templates. If we remove it, the user will not be able to go back
 to the original template using this flow (they would have to find the
 "clear customizations" option to do so)
 - home.html is what you would expect and uses the previous pattern

 The only one we could lose is template-home-business.php but I would
 rather address this were a last resort because it's a worse user
 experience

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59465#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform