[wp-trac] [WordPress Trac] #59945: About the feed name specified in the add_feed()

[WordPress Trac]

#59945: About the feed name specified in the add_feed()
--------------------------+---------------------
 Reporter:  tmatsuur      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.5
Component:  Feeds         |     Version:  1.5
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  docs
--------------------------+---------------------
Changes (by hellofromTonya):

 * keywords:   => needs-patch
 * focuses:   => docs
 * version:  2.1 => 1.5
 * milestone:  Awaiting Review => 6.5


Comment:

 Drilling further backwards in time, the RegEx that strips the `_` was
 first introduced in [1376], 20 years ago.
 https://core.trac.wordpress.org/browser/trunk/wp-feed.php?rev=1376#L9

 I'm not finding a ticket for it, i.e. to review the discussion of why it
 was needed.

 Replying to [comment:3 jorbin]:
 > With the knowledge that this has been in place for so long, my gut leans
 towards not wanting to make code changes but instead make this a
 documented part of the function.

 Given this feed naming limitation has existed for 20 years, I agree with
 @jorbin. Though I'd like to know why it's needed, changing this area of
 the code is risky, i.e. likely will have unintended side effects.

 Pulling into 6.5 and adding `needs-patch` to add the better documentation.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59945#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform