[wp-trac] [WordPress Trac] #59927: Missing error check in convert_smilies() can cause PHP Fatal error

[WordPress Trac]

#59927: Missing error check in convert_smilies() can cause PHP Fatal error
------------------------------------------------+---------------------
 Reporter:  Ov3rfly                             |       Owner:  (none)
     Type:  defect (bug)                        |      Status:  new
 Priority:  normal                              |   Milestone:  6.5
Component:  Formatting                          |     Version:
 Severity:  normal                              |  Resolution:
 Keywords:  php80 needs-unit-tests needs-patch  |     Focuses:
------------------------------------------------+---------------------
Changes (by jorbin):

 * keywords:  php80 => php80 needs-unit-tests needs-patch
 * milestone:  Awaiting Review => 6.5


Comment:

 Optimistically putting this in the 6.5 milestone.

 In my eyes, the biggest question is what should be expected when the regex
 fails. Perhaps throw an error but then continue without converted smilies?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59927#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform