[wp-trac] [WordPress Trac] #59960: Replace em-based `line-height` with unitless values

[WordPress Trac]

#59960: Replace em-based `line-height` with unitless values
-------------------------------------+-------------------------------------
 Reporter:  sabernhardt              |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch good-first-  |     Focuses:  css, administration,
  bug                                |  coding-standards
-------------------------------------+-------------------------------------

Comment (by sabernhardt):

 I found ten em-based `line-height` values in the CSS files within the `wp-
 admin` and `wp-includes` directories.

 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/common.css?rev=56956&marks=228,513,520,782#L223 4 rulesets in
 wp-admin\css\common.css]
 {{{
 /* Line 228 */
 body {
         line-height: 1.4em;
 }

 /* Line 513 */
 .widefat td,
 .widefat td p,
 .widefat td ol,
 .widefat td ul {
         line-height: 1.5em;
 }

 /* Line 520 */
 .widefat th,
 .widefat thead td,
 .widefat tfoot td {
         line-height: 1.3em;
 }

 /* Line 782 */
 .widget .widget-top,
 .postbox .hndle,
 .stuffbox .hndle,
 .control-section .accordion-section-title,
 .sidebar-name,
 #nav-menu-header,
 #nav-menu-footer,
 .menu-item-handle,
 .checkbox,
 .side-info,
 #your-profile #rich_editing,
 .widefat thead th,
 .widefat thead td,
 .widefat tfoot th,
 .widefat tfoot td {
         line-height: 1.4em;
 }
 }}}

 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/edit.css?rev=56948&marks=1418#L1416 wp-admin\css\edit.css (line
 1418)]
 {{{
 p.popular-tags {
         line-height: 2em;
 }
 }}}

 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/install.css?rev=56956&marks=93#L79 wp-admin\css\install.css
 (line 93)]
 {{{
 #logo {
         line-height: 1.3em;
 }
 }}}

 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/list-
 tables.css?rev=57093&marks=2252#L2250 wp-admin\css\list-tables.css (line
 2252)]
 {{{
 @media screen and (max-width: 782px) {
         table.plugin-install td.column-name strong {
                 line-height: 1.6em;
         }
 }
 }}}

 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/media.css?rev=56948&marks=203#L198 wp-admin\css\media.css (line
 203)]
 {{{
 .media-item .progress {
         line-height: 2em;
 }
 }}}

 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/nav-
 menus.css?rev=56956&marks=181#L176 wp-admin\css\nav-menus.css (line 181)]
 {{{
 .bulk-actions input.menu-items-delete {
         line-height: 2.1em;
 }
 }}}

 Thickbox styles (compiled from
 [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/vendor/thickbox/thickbox.css?rev=49309&marks=83#L78
 thickbox.css, line 83])
 {{{
 #TB_ajaxContent {
         line-height: 1.4em;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59960#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform