[wp-trac] [WordPress Trac] #59935: Site editor: logo

WordPress Trac noreply at wordpress.org
Tue Nov 21 12:24:37 UTC 2023


#59935: Site editor: logo
----------------------------------------+------------------------------
 Reporter:  priethor                    |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Editor                      |     Version:  6.4
 Severity:  normal                      |  Resolution:
 Keywords:  has-testing-info has-patch  |     Focuses:
----------------------------------------+------------------------------

Comment (by antonvlasenko):

 The issue that affected the `Site Logo` block, was introduced in
 https://core.trac.wordpress.org/ticket/57902, and resulted in the
 `site_icon` and `site_icon_url` fields being absent from the response,
 despite the `site_icon_url` field being included in the `_fields` GET
 parameter.
 [https://github.com/WordPress/wordpress-develop/pull/5691 The PR I am
 proposing] addresses this by ensuring that the `site_icon*` and
 `site_logo` fields are present in the response when they are explicitly
 requested in the `_fields` parameter.

 Steps to test https://github.com/WordPress/wordpress-develop/pull/5691:
 1. Navigate to `Appearance` -> `Editor`.
 2. Add a `Site Logo` block, upload an image to to it, and save the page.
 3. The top-left `W` should be replaced with the image you just uploaded.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59935#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list