[wp-trac] [WordPress Trac] #58361: Passing 'none' as 'menu_icon' to 'register_post_type' is not working correctly

WordPress Trac noreply at wordpress.org
Mon Nov 13 13:07:12 UTC 2023


#58361: Passing 'none' as 'menu_icon' to 'register_post_type' is not working
correctly
--------------------------------------------+------------------------------
 Reporter:  andrewleap                      |       Owner:  (none)
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  Awaiting Review
Component:  Administration                  |     Version:  3.0
 Severity:  minor                           |  Resolution:
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+------------------------------
Changes (by azaozz):

 * keywords:  has-patch needs-testing dev-feedback => has-patch needs-
     testing commit


Comment:

 Thanks for the ping @ironprogrammer. 58361.3.diff seems correct: `none`
 and `div` should not be escaped with `esc_url()`, they are special cases
 not URLs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58361#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list