[wp-trac] [WordPress Trac] #59783: Block Hooks: Mark and document publicly available global functions as being Core-only internal functions.

WordPress Trac noreply at wordpress.org
Mon Nov 6 12:48:27 UTC 2023


#59783: Block Hooks: Mark and document publicly available global functions as being
Core-only internal functions.
------------------------------+-----------------------------
 Reporter:  hellofromTonya    |       Owner:  hellofromTonya
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  6.4
Component:  Editor            |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  docs
------------------------------+-----------------------------
Changes (by hellofromTonya):

 * owner:  (none) => hellofromTonya
 * status:  new => reviewing


Comment:

 Patch: https://github.com/WordPress/wordpress-develop/pull/5607

 The patch fits the scope of this ticket, as it marks the remaining Blocks
 Hooks global functions as private.

 Though not required, I also like the added note within the docblock that
 further explains the functions are for Core internal usage only. Thinking
 that same note could be applied to the other non `_` functions added for
 Block Hooks, e.g. `make_after_block_visitor()` et al. I can add that same
 docblock explanation at commit prep.

 Prepping commit now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59783#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list