[wp-trac] [WordPress Trac] #54421: Deprecate skip link focus fix

WordPress Trac noreply at wordpress.org
Mon May 22 19:45:57 UTC 2023


#54421: Deprecate skip link focus fix
-------------------------+-------------------------------------------------
 Reporter:  westonruter  |       Owner:  sabernhardt
     Type:  defect       |      Status:  accepted
  (bug)                  |
 Priority:  normal       |   Milestone:  6.3
Component:  Bundled      |     Version:  3.6
  Theme                  |
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  accessibility, javascript,
                         |  performance
-------------------------+-------------------------------------------------

Comment (by sabernhardt):

 I restarted with a fresh branch for PR 4487. It includes the
 recommendations from @westonruter and @joedolson, but I hesitated to add
 the [https://github.com/sabernhardt/wordpress-
 develop/pull/22/files#r1199689434 code quality improvement] suggested by
 @mukesh27.

 Also, Twenty Sixteen's offset technically should have been `-67` for
 widths from 700 to 782 pixels and `-46` for narrower widths. However,
 encountering a problem with the 53-pixel offset would involve:
 1. Accessing a site that continues to enqueue this script,
 2. Using Internet Explorer,
 3. Sizing the window to the 700-782 pixel range (or zoom equivalent),
 4. Logging in to the site, and
 5. Activating the skip link.

 To //consider// increasing it for everyone, see the
 [https://github.com/WordPress/wordpress-
 develop/assets/17100257/7920ed5f-9987-4143-92b6-f82ad92144ce offset
 comparison] between 53 and 67 pixels.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54421#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list