[wp-trac] [WordPress Trac] #58317: Refactor determine_locale() for performance

WordPress Trac noreply at wordpress.org
Mon May 15 14:51:34 UTC 2023


#58317: Refactor determine_locale() for performance
----------------------------------------+-----------------------------
 Reporter:  Cybr                        |       Owner:  (none)
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  I18N                        |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  performance
----------------------------------------+-----------------------------
Changes (by swissspidy):

 * keywords:  has-patch => has-patch needs-unit-tests


Comment:

 Thanks a lot for putting together a patch & detailing the changes after
 previously mentioning your findings on Slack!


 +1 re: the `empty()` question above. I don't see any change in the numbers
 when adding that back in. But really just a detail if the behavior is the
 same.

 That said, as long as we have proper test coverage for this function then
 that doesn't matter too much.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58317#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list