[wp-trac] [WordPress Trac] #58196: Improve performance of `_get_block_templates_paths`

WordPress Trac noreply at wordpress.org
Tue May 2 21:31:01 UTC 2023


#58196: Improve performance of `_get_block_templates_paths`
-----------------------------------------+------------------------------
 Reporter:  spacedmonkey                 |       Owner:  (none)
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Themes                       |     Version:  5.9
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |     Focuses:  performance
-----------------------------------------+------------------------------

Comment (by flixos90):

 @spacedmonkey I conducted additional benchmarks with PR
 https://github.com/WordPress/wordpress-develop/pull/4397 (note that my
 benchmark results from [comment:7] was for your previous PR
 https://github.com/WordPress/wordpress-develop/pull/4383).

 * [https://docs.google.com/spreadsheets/d/1-a9qws0lb_ykc3g1TucRfGl6_L8y-
 pU1GMvH_8rlnQA/edit#gid=1487731787 Benchmark results against WP 6.2 on
 Local WP]
 * [https://docs.google.com/spreadsheets/d/1-a9qws0lb_ykc3g1TucRfGl6_L8y-
 pU1GMvH_8rlnQA/edit#gid=1331579124 Benchmark results against trunk in core
 dev environment]

 Unfortunately, both of those benchmarks produce similar results, showing
 only very small differences in performance. Overall load time (`wp-total`)
 so far is ~1% faster, which ''could'' be a legitimate small performance
 win, but also may be due to variance, so we would need to validate that
 with further benchmarks.

 That said, it still makes the previous benchmarks seeing the large
 performance improvements questionable - maybe it is something setup-
 specific? Have you tried benchmarking this on `trunk` with less overhead
 (i.e. no profiler running, `WP_DEBUG` etc constants disabled, ...)?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58196#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list