[wp-trac] [WordPress Trac] #57035: Error in current_time() function when using timestamp and no value for gmt_offset

WordPress Trac noreply at wordpress.org
Tue Mar 28 14:37:06 UTC 2023


#57035: Error in current_time() function when using timestamp and no value for
gmt_offset
-------------------------------------------------+-------------------------
 Reporter:  Nick_theGeek                         |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.3
Component:  Date/Time                            |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch php8 changes-requested     |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch php8 dev-feedback commit => has-patch php8 changes-
     requested needs-unit-tests
 * milestone:  6.2 => 6.3


Comment:

 Resetting the keywords and moving to 6.3 after the revert.

 With the gained knowledge of partial-hour timezones using float
 `'gmt_offset'` (see #57998), the patch will need adjustments.

 Also the existing tests for `current_time()` need additional datasets to
 test for a variety of timezones, especially those using `'timestamp'` or
 `'U'`. Data providers can be used.

 Thank you everyone for your contributions!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57035#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list