[wp-trac] [WordPress Trac] #57998: current_time function: GMT offset is not always an integer

[WordPress Trac]

#57998: current_time function: GMT offset is not always an integer
--------------------------------------+-----------------------
 Reporter:  reputeinfosystems         |       Owner:  (none)
     Type:  defect (bug)              |      Status:  reopened
 Priority:  normal                    |   Milestone:  6.2
Component:  Date/Time                 |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------
Changes (by hellofromTonya):

 * milestone:  6.2.1 => 6.2


Comment:

 After discussing in Make/Core with the Release Squad and Committers, there
 is consensus to revert [55054] now to ship in 6.2.0.

 **Why revert?**

 1. The additional impacts shared by @Rarst and @reputeinfosystems
 highlighted that this regression can impact bookings, date permalinks, and
 potentially stores for users in these [https://www.timeanddate.com/time
 /time-zones-interesting.html partial-hour timezones].
 2. The impacted user base includes India, Australia, and others, i.e.
 large population areas.
 3. Even if a fast 6.2.1 were released, the impacts could already have been
 felt by business owners, customers, extenders, and users.
 4. And then there are the unknowns or as @desrosj noted:
 >I also think that impossible to anticipate the full impact of this
 change.

 **Why not fix in 6.2.0?**
 There's not enough time in the cycle to validate the fix truly fixes the
 issue without causing an additional issue or side effect. Thus, a fix is
 too risky this late in the cycle. More time is needed to discuss, add more
 test coverage, and consider other edge cases and scenarios.

 The revert will impact the original ticket that introduced the changeset,
 i.e. #57035.

 Once reverted, then the regression reported in this ticket is fixed as the
 code is restored to pre-6.2 state. Thus, this ticket can be closed work
 continuing in #57035 with this new knowledge.

 Huge props to @reputeinfosystems for reporting this regression and @Rarst
 and @reputeinfosystems for sharing the additional impacts!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57998#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform