[wp-trac] [WordPress Trac] #57993: Update `$_old_files` array for version 6.2

[WordPress Trac]

#57993: Update `$_old_files` array for version 6.2
-----------------------------+----------------------------
 Reporter:  davidbaumwald    |       Owner:  davidbaumwald
     Type:  task (blessed)   |      Status:  assigned
 Priority:  normal           |   Milestone:  6.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+----------------------------

Comment (by hellofromTonya):

 The old Requests files are not listed in `$_old_files`, but instead are
 listed below it in `$_old_requests_files`. Why? To facilitate preloading
 the old files into memory before the update happens (see [54997]).

 What happens is this:

 1. In `update_core()`, the Requests list of files is merged into
 `$_old_files`.
 2. Then the Requests files are preloaded into memory via
 `_preload_old_requests_classes_and_interfaces()`.
 3. Then the rest of the `update_core()` code executes.

 The Requests files are listed separately from `$_old_files` to have a list
 of files to pass to `_preload_old_requests_classes_and_interfaces()` for
 preloading.

 But this new arrangement means the diff script needs adjustment to not
 only look in `$_old_files` but also in others. OR all of the files must
 also be added (duplicated)
  into `$_old_files` and the `array_merge()` removed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57993#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform