[wp-trac] [WordPress Trac] #57030: Condition is not strictly checked on options-general.php file

[WordPress Trac]

#57030: Condition is not strictly checked on options-general.php file
----------------------------+-------------------------------
 Reporter:  rakibwordpress  |       Owner:  SergeyBiryukov
     Type:  defect (bug)    |      Status:  assigned
 Priority:  normal          |   Milestone:  6.3
Component:  Administration  |     Version:  3.0
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:2 hellofromTonya]:
 > Also a note for consideration:
 > Will `$current_offset` ''always''**** be an integer `0`? Or could it be
 a string `'0'`? The current code will type juggle to compare the values
 without comparing the data types.

 This gets even more interesting, as the value can also be `float` or
 `false`, via `wp_timezone_override_offset()` hooked to
 `pre_option_gmt_offset` in `wp-includes/default-filters.php`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57030#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform