[wp-trac] [WordPress Trac] #57952: Able to delete multiple users with the Change button - STRANGE

[WordPress Trac]

#57952: Able to delete multiple users with the Change button - STRANGE
-------------------------------------------------+-------------------------
 Reporter:  haritpanchal                         |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.3
Component:  Users                                |     Version:
 Severity:  major                                |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |  administration
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Thanks for the patch!

 It looks like there is already some logic in
 `WP_Users_List_Table::current_action()` to set the action to `promote` if
 `$_REQUEST['changeit']` is set.

 The reason it doesn't work in this case is because it also checks that
 `$_REQUEST['new_role']` is not empty, which is not the case if we did not
 select a role.

 So I think a better solution would be to adjust that logic instead of
 duplicating it elsewhere, see [attachment:"57952.2.diff"].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57952#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform