[wp-trac] [WordPress Trac] #57922: Changing class-wp-editor.php Insert/Edit Link header from H1 to H3 or other

[WordPress Trac]

#57922: Changing class-wp-editor.php Insert/Edit Link header from H1 to H3 or other
-------------------------------+------------------------------
 Reporter:  donniewalden707    |       Owner:  (none)
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Editor             |     Version:  6.1.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:  ui
-------------------------------+------------------------------

Comment (by donniewalden707):

 Hey @audrasjb that's correct.

 While the code has a style of display:none - googles crawlers can still
 index that page and see that modal code. So it sees <h1> "Insert/edit
 link" </h1> as a leading title on the page and then tries to place it as
 useful information on the search. I've manually changed it to an h3, and
 it's fixed the issue.

 Just figured someone should know since it seems like a weird place to use
 an h1 tag. Not to mention I'll need to manually change it next core update
 most likely. We really shouldn't ever use H1 anywhere on a page if it's
 not the actual title of the page. I get it from the standpoint of the
 modal as a stand-alone object, but since the modal only ever features on
 the page and it's hidden by default, makes more sense to give it an H2 or
 an H3 if a title is needed. Crawlers are going to see it regardless, in
 the HTML, if it's hidden or not via styles.

 As for plugins - we are not using blocks everywhere plugin :)

 All the best,
 D

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57922#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform