[wp-trac] [WordPress Trac] #57683: Improve performance of mysql2date

WordPress Trac noreply at wordpress.org
Wed Mar 8 19:33:01 UTC 2023


#57683: Improve performance of mysql2date
--------------------------+-----------------------------
 Reporter:  spacedmonkey  |       Owner:  (none)
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Date/Time     |     Version:  0.71
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  performance
--------------------------+-----------------------------

Comment (by Rarst):

 I feel like this keeps circling back to "let's introduce a lot of
 complexity and/or side effects to not access this specific option".

 Accessing options is normal. It's not particularly slow (still need to
 double check what is autoload thinking about time zone ones). It's not
 worth severe issues with testing through static caches or complicating
 function signatures that are already (out of backwards compat necessity)
 too complex.

 If you are set on eliminating option access here - I suggest the string
 approach. It's good enough given that formats are fixed and being ancient
 global vars aren't likely to change around.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57683#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list