[wp-trac] [WordPress Trac] #57789: Make theme.json related caches persistent

WordPress Trac noreply at wordpress.org
Wed Mar 1 20:33:52 UTC 2023


#57789: Make theme.json related caches persistent
-------------------------+--------------------------
 Reporter:  flixos90     |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  6.3
Component:  Themes       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:  performance
-------------------------+--------------------------

Comment (by flixos90):

 @iCaleb Your idea certainly sounds interesting, however there is still the
 concern about how that affects filter callback logic that runs due to the
 filters from the logic that generates the data which is then cached.
 Whenever the cached data is returned, those filters aren't run. Which
 maybe is fine for some, but is not an expected situation, and with the
 scale of WordPress I'm sure will lead to breakage.

 So the problems here are partially invalidation, partially filters in the
 logic that is no longer executed when cached (see @oandregal's comment for
 more details).

 @spacedmonkey Regarding the existing `theme` cache group, I think we
 should avoid intertwining with that. There are different implications for
 that cache group, and opting in to making it persistent ''can'' be a good
 idea. Whereas if you now opted in to making the `theme-json` cache group
 persistent, you would effectively opt in into broken behavior, which IMO
 is not something we should offer or encourage.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57789#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list