[wp-trac] [WordPress Trac] #58674: Fix incorrect hook being used as separator between `wp-before-template` and `wp-template` metrics in automated performance tests

WordPress Trac noreply at wordpress.org
Fri Jun 30 15:33:52 UTC 2023


#58674: Fix incorrect hook being used as separator between `wp-before-template` and
`wp-template` metrics in automated performance tests
-------------------------------------------+--------------------------
 Reporter:  flixos90                       |       Owner:  joemcgill
     Type:  defect (bug)                   |      Status:  accepted
 Priority:  normal                         |   Milestone:  6.3
Component:  Build/Test Tools               |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  needs-patch reporter-feedback  |     Focuses:  performance
-------------------------------------------+--------------------------
Changes (by joemcgill):

 * keywords:  needs-patch => needs-patch reporter-feedback
 * owner:  (none) => joemcgill
 * status:  new => accepted


Comment:

 Thanks @felix, I'm not sure what you're proposing is the right approach
 here. I would argue that determining which template to load is part of the
 template loading process, and any server timing related to that process
 should be included in the reported numbers for the `wp-template` value. Is
 there a reason that the `template_include` filter was chosen for the
 Performance Lab plugin that should be applied in the automated WP tests?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58674#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list