[wp-trac] [WordPress Trac] #58206: Replace usage of strpos with str_contains

[WordPress Trac]

#58206: Replace usage of strpos with str_contains
-------------------------------------+-------------------------------------
 Reporter:  spacedmonkey             |       Owner:  SergeyBiryukov
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  6.3
Component:  General                  |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  good-first-bug 2nd-      |     Focuses:  performance, coding-
  opinion needs-patch                |  standards
-------------------------------------+-------------------------------------
Changes (by azaozz):

 * keywords:  good-first-bug has-patch 2nd-opinion commit => good-first-bug
     2nd-opinion needs-patch
 * severity:  normal => blocker


Comment:

 Another place where it seems the polifills cannot be used is in `update-
 core.php`. The problem seems to be that when auto-updating core this file
 is downloaded first and runs in the old WP version first. So if a polifill
 is missing from the old version but used in `update-core.php`, it throws a
 fatal error.

 Seems this was the reason auto-updates from WP 5.7 and earlier to
 6.3-beta1 failed, see:
 https://wordpress.slack.com/archives/C02RQBWTW/p1687896726091119.

 Setting this to the highest priority as it needs a patch asap.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58206#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform