[wp-trac] [WordPress Trac] #58637: HTML API: Fatal error processing document with unclosed attribute

WordPress Trac noreply at wordpress.org
Tue Jun 27 13:01:09 UTC 2023


#58637: HTML API: Fatal error processing document with unclosed attribute
-------------------------------------------------+-------------------------
 Reporter:  dlh                                  |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  HTML API                             |     Version:  6.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests needs-patch dev-      |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by dmsnell):

 I've uploaded a new patch with the fix that checks the index before use
 and adds a number of other tests to the suite. Without the patch to the
 tag processor the `<iframe src="…` fails, but with the patch it succeeds.

 Not sure how we missed this because it's the exact same kind of situation
 that we found on WordPress.com before the merge (and we fixed it), but I
 reviewed the other existing uses of `strpos()` and it looks like they are
 all guarded.

 @dlh I've uploaded this patch because your PR is on your own git fork,
 which is fine, but I can't push to it. If you want you can adopt it in the
 PR.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58637#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list