[wp-trac] [WordPress Trac] #12009: Add support for HTML 5 "async" and "defer" attributes

WordPress Trac noreply at wordpress.org
Tue Jun 27 01:14:13 UTC 2023


#12009: Add support for HTML 5 "async" and "defer" attributes
---------------------------------------------+--------------------------
 Reporter:  Otto42                           |       Owner:  joemcgill
     Type:  enhancement                      |      Status:  assigned
 Priority:  high                             |   Milestone:  6.3
Component:  Script Loader                    |     Version:  4.6
 Severity:  normal                           |  Resolution:
 Keywords:  needs-dev-note has-patch commit  |     Focuses:  performance
---------------------------------------------+--------------------------
Changes (by joemcgill):

 * keywords:  needs-dev-note has-patch => needs-dev-note has-patch commit


Comment:

 Replying to [comment:147 TobiasBg]:

 Always good to double check these things, so thank you for raising the
 concern about these two files potentially being committed accidentally.

 > Now, if the `.jshintrc` changes are not strictly necessary for the
 purpose of this ticket, they should maybe go in their own documented
 commit (after reverting that part of [56033] first). The scenario that I'm
 thinking about here is a developer stumbling upon e.g. `"console": false`
 in the future but not finding explanations when `blame`ing the changes.
 After all, globally allow-listing `console` might cover/cloak the
 accidental addition of debug code in a commit and therefore doesn't come
 fully risk-free.

 This is a fair argument for reverting this part of the change and letting
 someone add them back if/when the situation arises again. I've add a
 [https://github.com/WordPress/wordpress-develop/pull/4708 new PR] that
 reverts those changes and will commit once ensuring all tests pass.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/12009#comment:149>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list