[wp-trac] [WordPress Trac] #58220: Replace usage of substr with str_starts_with and str_ends_with

WordPress Trac noreply at wordpress.org
Sun Jun 25 10:48:42 UTC 2023


#58220: Replace usage of substr with str_starts_with and str_ends_with
------------------------------+-----------------------------
 Reporter:  Soean             |       Owner:  SergeyBiryukov
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  6.3
Component:  General           |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  performance
------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"56021" 56021]:
 {{{
 #!CommitTicketReference repository="" revision="56021"
 Code Modernization: Use `str_contains()` in a few more places.

 `str_contains()` was introduced in PHP 8.0 to perform a case-sensitive
 check indicating if the string to search in (haystack) contains the given
 substring (needle).

 WordPress core includes a polyfill for `str_contains()` on PHP < 8.0 as of
 WordPress 5.9.

 This commit replaces `false !== strpos( ... )` with `str_contains()` in
 core files, making the code more readable and consistent, as well as
 better aligned with modern development practices.

 Follow-up to [55988].

 Props spacedmonkey.
 See #58220.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58220#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list