[wp-trac] [WordPress Trac] #58206: Replace usage of strpos with str_contains

WordPress Trac noreply at wordpress.org
Fri Jun 23 15:54:10 UTC 2023


#58206: Replace usage of strpos with str_contains
-------------------------------------+-------------------------------------
 Reporter:  spacedmonkey             |       Owner:  SergeyBiryukov
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  6.3
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  performance, coding-
  patch 2nd-opinion commit           |  standards
-------------------------------------+-------------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:32 joedolson]:
 > Seems to be a problem in `install.php`, as well.

 Thanks! Yes, it looks like there's a similar issue with `wp-load.php`,
 triggered via `wp-admin/install.php`. In that instance, it might be
 preferable to include `compat.php`, as the site is not installed yet, so
 the overhead of including an extra file is negligible.

 It might also be beneficial to load `compat.php` a bit earlier in `wp-
 settings.php`, so that [source:tags/6.2.2/src/wp-
 settings.php?marks=39-49#L32 a few more files] could use the polyfills
 going forward.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58206#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list