[wp-trac] [WordPress Trac] #3534: Hide password in setup-config.php

WordPress Trac noreply at wordpress.org
Fri Jun 23 14:18:19 UTC 2023


#3534: Hide password in setup-config.php
-------------------------------------------------+-------------------------
 Reporter:  xmarcos                              |       Owner:  joedolson
     Type:  enhancement                          |      Status:  reviewing
 Priority:  low                                  |   Milestone:  6.3
Component:  Upgrade/Install                      |     Version:  2.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-testing-info has-      |     Focuses:
  screenshots dev-feedback                       |  accessibility
-------------------------------------------------+-------------------------

Comment (by sabernhardt):

 1. On the Install page, the Password field and button do not go to the
 opposite edge to match the other fields. Using 100% might help a little at
 larger screen widths, and it needs to be that wide on small screens.
 {{{
 .password-input-wrapper {
         display: inline-block;
         width: 100%;
 }
 }}}

 2. In RTL on smaller screens, `setup-config` positions the button above
 the input with no left padding.
 {{{
         .form-table td input[type="password"] {
                 /* rtl:ignore */
                 padding-right: 2.5rem;
         }
 }}}
  could be changed to
 {{{
         #pwd {
                 padding-right: 2.5rem;
         }
 }}}
  (The button is on the left on larger screens, so it should stay on the
 same side for smaller screens.)

 3. Consider giving the middle cells for `setup-config` a fixed width of
 about 300 pixels, and then reset it to `auto` (or 100%) for smaller
 screens. I don't like how the inputs expand and the description column
 shifts when clicking the toggle button. The Password field can also be
 quite narrow in languages with wide translations of Show and/or Hide.
 {{{
 .setup-config-fields th + td {
         width: 300px;
 }
 @media screen and (max-width: 782px) {
         .setup-config-fields th + td {
                 width: 100%;
         }
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/3534#comment:90>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list