[wp-trac] [WordPress Trac] #57893: Remove the redundancy of adding row actions in `class-wp-media-list-table.php`

WordPress Trac noreply at wordpress.org
Tue Jun 20 15:45:40 UTC 2023


#57893: Remove the redundancy of adding row actions in `class-wp-media-list-
table.php`
-------------------------------------------------+-------------------------
 Reporter:  kebbet                               |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  6.3
Component:  Media                                |     Version:  3.1
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch needs-testing has-         |     Focuses:  ui
  testing-info                                   |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55949" 55949]:
 {{{
 #!CommitTicketReference repository="" revision="55949"
 Media: Display the “Copy URL” and “Download file” row actions when the
 “Unattached” filter is applied.

 Due to partially duplicated logic for displaying row actions in the Media
 Library with and without the “Unattached” filter, the “Copy URL” and
 “Download file” row actions were unintentionally missing with the filter
 applied.

 This commit aims to simplify the logic and bring more consistency to the
 code.

 Includes displaying the “Download file” row action even when the “Trash”
 filter is applied, giving the user one more chance to download the media
 file before they delete it.

 Follow-up to [8901], [13100], [16227], [16229], [52842], [55198], [55221].

 Props kebbet, costdev, pbiron, oglekler, SergeyBiryukov.
 Fixes #57890, #57893.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57893#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list